Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language-service): add style scoped and module completion #4705

Merged
merged 5 commits into from
Aug 26, 2024
Merged

feat(language-service): add style scoped and module completion #4705

merged 5 commits into from
Aug 26, 2024

Conversation

runyasak
Copy link
Contributor

@runyasak runyasak commented Aug 18, 2024 •
edited
Loading

Updated

  • add style module completion with a new screenshot
  • change to style module completion instead of style scoped with a new screenshot

Overview

I've added the scoped and module attributes to style completion items.
Now, when we type style in completion, scoped and module are available as options.

Screenshots

Screen.Recording.2567-08-19.at.01.14.32.mov

This is my first PR. If you have any feedback or suggestions, please do not hesitate to let me know.

@KazariEX
Copy link
Collaborator

KazariEX commented Aug 18, 2024 •
edited
Loading

I think there is no need to extract languages to the top level, as it might be obtained from provider in the future. #4645

What about module?

@runyasak
Copy link
Contributor Author

I think there is no need to extract languages to the top level, as it might be obtained from provider in the future. #4645

What about module?

Hi @KazariEX, I apologize for not seeing your PR earlier.
Are you referring to CSS Modules?
If no one is assigned to this feature, may I contribute to it?
Should I create a new PR or update this one?

@KazariEX
Copy link
Collaborator

Just update directly, I think they belong to the same feature.

@runyasak runyasak changed the title feat(language-service): add style scoped completion feat(language-service): add style module completion Aug 18, 2024
@runyasak
Copy link
Contributor Author

@KazariEX I've updated my PR to module.
Please review my code again.

@KazariEX
Copy link
Collaborator

Sorry I didn't mean replacement but both scoped and module.

@runyasak
Copy link
Contributor Author

Sorry I didn't mean replacement but both scoped and module.

No problem. I will update now.

KazariEX

This comment was marked as duplicate.

Sign in to view

@runyasak runyasak changed the title feat(language-service): add style module completion feat(language-service): add style scoped and module completion Aug 18, 2024
@runyasak
Copy link
Contributor Author

@KazariEX I've updated my PR with attr as your suggestion.
Please review my PR again.

@runyasak runyasak requested a review from KazariEX August 18, 2024 18:20
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 26, 2024

commit: 686384a

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4705

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4705

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4705

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4705

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4705

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4705

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4705

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4705

Open in Stackblitz

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit 333d73e into vuejs:master Aug 26, 2024
5 checks passed
@mcsaur mcsaur mentioned this pull request Sep 20, 2024
Open
@WontonSam WontonSam mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazariEX KazariEX KazariEX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@runyasak @KazariEX @johnsoncodehk